Skip to content

Create a new TestLogger#57

Merged
Jean85 merged 1 commit into
php-fig:masterfrom
gmponos:patch-2
Nov 20, 2018
Merged

Create a new TestLogger#57
Jean85 merged 1 commit into
php-fig:masterfrom
gmponos:patch-2

Conversation

@gmponos

@gmponos gmponos commented Nov 20, 2018

Copy link
Copy Markdown
Contributor

Created a new TestLogger according to
Seldaek/monolog#1229

@Jean85

Jean85 commented Nov 20, 2018

Copy link
Copy Markdown
Member

@Seldaek you're the editor for this PSR, so you have to evaluate if this is a BC of the spec or can be merged without issues as an "errata".

Let me know how you want to proceed.

@Seldaek

Seldaek commented Nov 20, 2018

Copy link
Copy Markdown
Collaborator

IMO this is only about the library here (as in "util" package in other PSRs) and not related to the PSR spec itself so I'd say go for it.

@Jean85

Jean85 commented Nov 20, 2018

Copy link
Copy Markdown
Member

Good! Since you're the editor, I've given you write access to this repo.

Would you like to release it? Or should I do it?

@Jean85 Jean85 merged commit 6c001f1 into php-fig:master Nov 20, 2018
@Seldaek

Seldaek commented Nov 20, 2018

Copy link
Copy Markdown
Collaborator

Feel free to go ahead and release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants