Restart event handler - #632
Merged
Merged
Conversation
Currently not working: test should fail but not at this stage 🤔
Collaborator
Author
|
I've confirmed that I could reproduce the issue and that the proposed fix (once the tests are sorted out) fixes the issue on a local cluster. |
adam-sandor
pushed a commit
that referenced
this pull request
Oct 28, 2021
Properly start event handler when starting the event source. Minor clean-ups. Fixes #630 Co-authored-by: csviri <csviri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lburgazzoli @csviri I'm probably missing something obvious but I don't understand why the tests are failing where they are failing (they should be failing here: https://github.com/java-operator-sdk/java-operator-sdk/compare/restart-event-handler?expand=1#diff-4e4a9d7fa25947b6995ea23a9d0e96427e24c2d0182ddb735e6b3d75a6e54898R146)