Skip to content

Fix RTL: isolate dir overrides and support dynamic dir updates#844

Merged
andycall merged 2 commits into
mainfrom
fix/rtl_2
Feb 3, 2026
Merged

Fix RTL: isolate dir overrides and support dynamic dir updates#844
andycall merged 2 commits into
mainfrom
fix/rtl_2

Conversation

@andycall

@andycall andycall commented Feb 3, 2026

Copy link
Copy Markdown
Member

What

  • Fixes RTL inline layout when descendants override direction (e.g. dir="ltr" phone numbers inside dir="rtl").
  • Supports dynamic updates to
    documentElement.dir and ensures logical margins remap correctly.

How

  • Insert Unicode bidi isolate controls for element-level dir changes during inline item collection
    and emit them into the paragraph.
  • Update logical margin mapping to respect direction changes.

Tests

  • Added widget regression: webf/test/src/rendering/ rtl_inline_dir_isolate_test.dart.
  • Added integration spec + snapshots:
    • integration_tests/specs/css/css-rtl/rtl-inline-dir-isolate.ts
    • integration_tests/specs/css/ css-inline-formatting/dir-dynamic-update.ts

@vercel

vercel Bot commented Feb 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
use-case Ready Ready Preview, Comment Feb 3, 2026 7:50pm
vue_usecase Ready Ready Preview, Comment Feb 3, 2026 7:50pm

Request Review

@andycall andycall merged commit 61d0e3f into main Feb 3, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant