Skip to content

[release-4.14] OCPBUGS-90614: Fix JSON annotation parsing to prevent OperatorHub crash#16659

Open
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.14from
openshift-cherrypick-robot:cherry-pick-16588-to-release-4.14
Open

[release-4.14] OCPBUGS-90614: Fix JSON annotation parsing to prevent OperatorHub crash#16659
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-4.14from
openshift-cherrypick-robot:cherry-pick-16588-to-release-4.14

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #16588

/assign cardil

Harden annotation parsing for OperatorHub page to prevent TypeError
when PackageManifest annotations contain malformed or non-array JSON.

- Add parseJSONArrayAnnotation() with type validation
- Guard .reduce()/.map() calls on parsed annotation data
- Add optional chaining to installModesFor() for missing status/channels
- Add unit tests for annotation parsing edge cases

Backport of fix from PR openshift#14260 (OCPBUGS-35744) adapted for 4.16.

Assisted-by: 🤖 Claude Opus/Sonnet 4.6
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6da15b14-314d-4681-97d3-5aef82ed64e5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from TheRealJon and cajieh June 22, 2026 13:13
@openshift-ci openshift-ci Bot added the component/olm Related to OLM label Jun 22, 2026
@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign logonoff for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the component/shared Related to console-shared label Jun 22, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-88027 has been cloned as Jira Issue OCPBUGS-90614. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-90614: Fix JSON annotation parsing to prevent OperatorHub crash

Details

In response to this:

This is an automated cherry-pick of #16588

/assign cardil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.14] OCPBUGS-88027: Fix JSON annotation parsing to prevent OperatorHub crash [release-4.14] OCPBUGS-90614: Fix JSON annotation parsing to prevent OperatorHub crash Jun 22, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 22, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-90614, which is invalid:

  • expected dependent Jira Issue OCPBUGS-88027 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-88027 to target a version in 4.15.0, 4.15.z, but it targets "4.16.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #16588

/assign cardil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 22, 2026
@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 68375c6 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/olm Related to OLM component/shared Related to console-shared jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants