Skip to content

Sync readme and client timeout changes#151

Merged
ewanharris merged 2 commits into
mainfrom
chore/sync-timeout-docs-changes
Nov 26, 2024
Merged

Sync readme and client timeout changes#151
ewanharris merged 2 commits into
mainfrom
chore/sync-timeout-docs-changes

Conversation

@ewanharris

Copy link
Copy Markdown
Member

Description

Syncs the new client wide request timeout and docs changes across from the generator ahead of a release

References

openfga/sdk-generator#416
openfga/sdk-generator#403

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)

@ewanharris ewanharris requested review from a team as code owners November 26, 2024 15:01
@ewanharris ewanharris changed the title feat: support for providing a client wide request timeout Sync readme and timeout changes Nov 26, 2024
@ewanharris ewanharris changed the title Sync readme and timeout changes Sync readme and client timeout changes Nov 26, 2024
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.79%. Comparing base (5e61ff0) to head (76d70f4).

Files with missing lines Patch % Lines
openfga_sdk/configuration.py 84.61% 2 Missing ⚠️
openfga_sdk/rest.py 50.00% 1 Missing ⚠️
openfga_sdk/sync/rest.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
+ Coverage   68.77%   68.79%   +0.02%     
==========================================
  Files         124      124              
  Lines        9914     9929      +15     
==========================================
+ Hits         6818     6831      +13     
- Misses       3096     3098       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewanharris ewanharris added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 8434eea Nov 26, 2024
@ewanharris ewanharris deleted the chore/sync-timeout-docs-changes branch November 26, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants