fix: correct usage of the sdk method header#142
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 69.17% 69.07% -0.10%
==========================================
Files 122 122
Lines 9771 9741 -30
==========================================
- Hits 6759 6729 -30
Misses 3012 3012 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the Python SDK is sending the sdk method header for all requests, the expectation (and behaviour in other SDKs) for this header is that it is only sent for SDK methods that are wrappers of APIs as the intent is to provide a way for implementors of OpenFGA to track usage of these SDK wrapper methods.
So it should be sent for:
read_latest_authorization_modelwriteCLIENT_BULK_REQUEST_ID_HEADERwhen not in transaction modewrite_tuplesCLIENT_BULK_REQUEST_ID_HEADERwhen not in transaction mode (handled viawrite)delete_tuplesCLIENT_BULK_REQUEST_ID_HEADERwhen not in transaction mode (handled viawrite)batch_checkCLIENT_BULK_REQUEST_ID_HEADERlist_relationsCLIENT_BULK_REQUEST_ID_HEADERwhen not in transaction modeReferences
openfga/sdk-generator#435
Review Checklist
mainIf you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)