Skip to content

lib,src: remove --no-experimental-websocket CLI flag - #65284

Open
aduh95 wants to merge 3 commits into
nodejs:mainfrom
aduh95:no-experimental-websocket
Open

lib,src: remove --no-experimental-websocket CLI flag#65284
aduh95 wants to merge 3 commits into
nodejs:mainfrom
aduh95:no-experimental-websocket

Conversation

@aduh95

@aduh95 aduh95 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 14, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Aug 14, 2026
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (91a99c5) to head (ec413b5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65284      +/-   ##
==========================================
- Coverage   90.32%   90.31%   -0.01%     
==========================================
  Files         751      751              
  Lines      250000   249990      -10     
  Branches    47231    47225       -6     
==========================================
- Hits       225816   225784      -32     
- Misses      15566    15581      +15     
- Partials     8618     8625       +7     
Files with missing lines Coverage Δ
lib/internal/process/pre_execution.js 97.69% <ø> (-0.03%) ⬇️
src/node_options.cc 79.39% <100.00%> (-0.02%) ⬇️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread doc/api/globals.md Outdated
Comment thread doc/api/globals.md Outdated
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants