sqlite: aggregate constants in a single property#56213
Merged
nodejs-github-bot merged 5 commits intoDec 17, 2024
Merged
Conversation
cjihrig
approved these changes
Dec 10, 2024
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
A couple docs comments, but LGTM.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56213 +/- ##
==========================================
+ Coverage 88.49% 88.53% +0.03%
==========================================
Files 656 657 +1
Lines 189261 190208 +947
Branches 36348 36525 +177
==========================================
+ Hits 167493 168396 +903
- Misses 14977 14996 +19
- Partials 6791 6816 +25
|
cjihrig
approved these changes
Dec 10, 2024
jasnell
approved these changes
Dec 11, 2024
Renegade334
reviewed
Dec 11, 2024
LiviaMedeiros
left a comment
Member
There was a problem hiding this comment.
I wonder if we can omit SQLITE_ prefix for these constants.
ZYSzys
approved these changes
Dec 13, 2024
RafaelGSS
approved these changes
Dec 13, 2024
Collaborator
Qard
approved these changes
Dec 13, 2024
Collaborator
Collaborator
|
Landed in a73c41c |
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #56193
Closes: #56193