tools: fix type sniffing for properties in JSON generation#4884
tools: fix type sniffing for properties in JSON generation#4884TimothyGu wants to merge 1 commit into
Conversation
|
LGTM with a couple of nits: the commit should target |
|
@mscdex, done. |
|
LGTM |
|
Ping. |
|
I don't think running CI does anything with CI: https://ci.nodejs.org/job/node-test-pull-request/1442/ |
|
Not sure what's up with the ARM hosts in CI right now (stuck in pending, won't start a CI run) but everything else is green. This probably isn't even anything anyone will ever run on ARM anyway since it's internal tooling. And CI doesn't even exercise this code, so the CI run is kind of a symbolic gesture more than anything else. So, will land in another minute or two... |
|
|
PR-URL: nodejs#4884 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
|
Landed in ab45390 |
PR-URL: #4884 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
PR-URL: #4884 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
PR-URL: #4884 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
PR-URL: #4884 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
PR-URL: nodejs#4884 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Before:
{ "textRaw": "`children` {Array} ", "name": "children", "desc": "<p>The module objects required by this one.\n\n</p>\n" },(https://nodejs.org/api/modules.json)
After:
{ "textRaw": "`children` {Array} ", "type": "Array", "name": "children", "desc": "<p>The module objects required by this one.\n\n</p>\n" },