Skip to content

test: replace deprecated util.debug() calls#3082

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:rm-common-debug
Closed

test: replace deprecated util.debug() calls#3082
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:rm-common-debug

Conversation

@Trott

@Trott Trott commented Sep 26, 2015

Copy link
Copy Markdown
Member

common.debug() is just util.debug() and emits a deprecation notice. Per docs, use console.error() instead.

@Trott Trott added smoketest test Issues and PRs related to the tests. and removed smoketest labels Sep 26, 2015
Comment thread test/parallel/test-fs-realpath.js Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line can simply be removed

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@targos I think you're right. Done!

@Trott

Trott commented Sep 27, 2015

Copy link
Copy Markdown
Member Author

@targos

targos commented Sep 28, 2015

Copy link
Copy Markdown
Member

LGTM

common.debug() is just util.debug() and emits a deprecation notice. Per
docs, use console.error() instead.

PR-URL: nodejs#3083
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Trott added a commit that referenced this pull request Sep 28, 2015
common.debug() is just util.debug() and emits a deprecation notice. Per
docs, use console.error() instead.

PR-URL: #3082
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@Trott

Trott commented Sep 28, 2015

Copy link
Copy Markdown
Member Author

Landed in 44efd66

@Trott Trott closed this Sep 28, 2015
Trott added a commit that referenced this pull request Sep 30, 2015
common.debug() is just util.debug() and emits a deprecation notice. Per
docs, use console.error() instead.

PR-URL: #3082
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
This was referenced Sep 30, 2015
Trott added a commit that referenced this pull request Sep 30, 2015
common.debug() is just util.debug() and emits a deprecation notice. Per
docs, use console.error() instead.

PR-URL: #3082
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@Trott Trott deleted the rm-common-debug branch January 13, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants