Assorted typo fixes.#29075
Closed
XhmikosR wants to merge 1 commit into
Closed
Conversation
Contributor
|
As far as at least commit messages in changelogs go, we usually leave those alone, even if there were spelling mistakes. |
Contributor
Author
|
It's a semi-automated fix, so this was easier for me... |
Contributor
Author
|
For the site nodejs/nodejs.org#2375 |
Contributor
Author
|
Regardless, I can revert the commit message changes here and in the website PR if you guys prefer that. |
mcollina
reviewed
Aug 10, 2019
mcollina
left a comment
Member
There was a problem hiding this comment.
The changes to the changelog files are still there
Contributor
Author
|
Yeah because I didn't get a definitive answer about it.
I will rebase and drop them in a while.
…On Sat, Aug 10, 2019, 11:36 Matteo Collina ***@***.***> wrote:
***@***.**** commented on this pull request.
The changes to the changelog files are still there
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#29075?email_source=notifications&email_token=AACVLNJRWT7YSCDCHVERCTTQDZ4XTA5CNFSM4IKYU3Q2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCBGAJ6A#pullrequestreview-273417464>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACVLNL245M2ROHLXD5MBZDQDZ4XTANCNFSM4IKYU3QQ>
.
|
Contributor
Author
|
Done. |
addaleax
approved these changes
Aug 10, 2019
Trott
approved these changes
Aug 10, 2019
cjihrig
approved these changes
Aug 10, 2019
lpinca
approved these changes
Aug 10, 2019
Member
Member
|
Landed in f114e5b |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 12, 2019
PR-URL: nodejs#29075 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 19, 2019
PR-URL: #29075 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Aug 20, 2019
This was referenced Jan 20, 2021
This was referenced Sep 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes