fs: unecessary argument validation

[ronag]

Writable already assures that only Buffer's are passed to _write. Also this is not the "correct" way to handle errors inside _write.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• documentation is changed or added
• tests and/or benchmarks are included
• commit message follows commit guidelines

[mscdex]

It's not ensured because the user's options passed to fs.createWriteStream() is passed directly to Writable(). So if a user has decodeStrings: false in options, _write() will get passed a string.

[ronag]

Should that even be a valid option for fs? That option is for Writable implementors. Not users.

[ronag]

I’ll update the PR if the consensus is to keep the check. But the error needs to be passed to the callback to ‘Writable’ and not directly emitted.

Also do we then also need this check for writev?

[ronag]

Fixed so that decodeStrings is always true.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/24931/

[ronag]

@Trott this seems ready?

[Trott]

@Trott this seems ready?

Seems like it. @nodejs/streams @mcollina Do you have any thoughts on this one? (EDIT: Yeah, I'm being super extra cautious, I guess.)

[Trott]

Extra-cautious CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1970/ (queued)

[danbev]

@ronag Would you be able to rebase this and take a look at the conflict? Thanks

[ronag]

@danbev: rebased