fs: document the Date conversion in Stats objects#28224
Closed
joyeecheung wants to merge 2 commits into
Closed
Conversation
Document why the dates are calculated with the timestamp in Numbers + 0.5. The comment was previously lost in a revert. Refs: nodejs@ae6c704
Collaborator
|
Sadly, an error occurred when I tried to trigger a build. :( |
Member
Author
|
cc @nodejs/fs |
Collaborator
Member
Author
|
cc'ing people who reverted the original commit @addaleax @TimothyGu @refack @cjihrig |
Collaborator
addaleax
approved these changes
Jun 17, 2019
jasnell
approved these changes
Jun 17, 2019
Trott
reviewed
Jun 17, 2019
Trott
approved these changes
Jun 17, 2019
Trott
left a comment
Member
There was a problem hiding this comment.
LGTM with or without small typo in comment fixed.
Collaborator
BridgeAR
approved these changes
Jun 17, 2019
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jun 17, 2019
Document why the dates are calculated with the timestamp in Numbers + 0.5. The comment was previously lost in a revert. Refs: nodejs@ae6c704 PR-URL: nodejs#28224 Refs: nodejs@ae6c704 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
|
Landed in b6326ce 🎉 |
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
Document why the dates are calculated with the timestamp in Numbers + 0.5. The comment was previously lost in a revert. Refs: ae6c704 PR-URL: #28224 Refs: ae6c704 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2019
Document why the dates are calculated with the timestamp in Numbers + 0.5. The comment was previously lost in a revert. Refs: ae6c704 PR-URL: #28224 Refs: ae6c704 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document why the dates are calculated with the timestamp
in Numbers + 0.5.
The comment was previously lost in a revert.
Refs: ae6c704
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes