Skip to content

test: add regression test for #11257#20391

Closed
bcoe wants to merge 1 commit into
nodejs:masterfrom
bcoe:test-for-11257
Closed

test: add regression test for #11257#20391
bcoe wants to merge 1 commit into
nodejs:masterfrom
bcoe:test-for-11257

Conversation

@bcoe

@bcoe bcoe commented Apr 28, 2018

Copy link
Copy Markdown
Contributor

adds regression test for #11257, I've confirmed that this test fails on versions of Node < 8, and works on latest.

CC: @michaelglass, @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 28, 2018
@Trott

Trott commented Apr 29, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

There's a couple of lint issues with the file. Run make lint-js (or, I think, vcbuild lint-js if you are on Windows) to see them. (Incidentally, make -j4 test will also run the linter, assuming no tests are failing.)

@apapirovski

apapirovski commented May 3, 2018

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/14653/

@bcoe

bcoe commented May 4, 2018

Copy link
Copy Markdown
Contributor Author

I'm digging into the Windows test failure, it's taking me a little while to get my Windows development environment back in tip-top shape.

@bcoe bcoe force-pushed the test-for-11257 branch from 2169b76 to 50adc34 Compare May 4, 2018 20:46
@bcoe

bcoe commented May 4, 2018

Copy link
Copy Markdown
Contributor Author

@apapirovski okay, you should be able to kick of Windows tests again.

bcoe
bcoe commented May 4, 2018
View reviewed changes
Comment thread test/parallel/test-stdio-pipe-stderr.js

stream.on('open', () => {
spawn(process.execPath, {
input: `require("${fakeModulePath.replace(/\\/g, '/')}")`,

@bcoe bcoe May 4, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was resulting in require("C:\\foo\bar") vs., require("c:\\\\foo\\bar\\apple").

mhdawson
mhdawson approved these changes May 7, 2018
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson

mhdawson commented May 7, 2018

Copy link
Copy Markdown
Member

New CI run: https://ci.nodejs.org/job/node-test-pull-request/14705/

@TimothyGu TimothyGu mentioned this pull request May 9, 2018
Closed
@mhdawson

mhdawson commented May 10, 2018

Copy link
Copy Markdown
Member

CI was good landing.

@mhdawson

mhdawson commented May 10, 2018

Copy link
Copy Markdown
Member

Landed as d942573

@mhdawson mhdawson closed this May 10, 2018
mhdawson pushed a commit that referenced this pull request May 10, 2018
@mhdawson
test: add regression test for #11257
d942573 
Refs: #11257

PR-URL: #20391
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
targos pushed a commit that referenced this pull request May 12, 2018
@targos
test: add regression test for #11257
41e1dc0 
Refs: #11257

PR-URL: #20391
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@gireeshpunathil gireeshpunathil mentioned this pull request May 14, 2018
Closed
@addaleax addaleax mentioned this pull request May 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

+3 more reviewers

@apapirovski apapirovski apapirovski approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@mhdawson mhdawson mhdawson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bcoe @Trott @apapirovski @mhdawson @jasnell @TimothyGu @nodejs-github-bot