test: changed common.fixturesDir to use common.fixtures module#15904
Closed
RaphaelRheault wants to merge 1 commit into
Closed
test: changed common.fixturesDir to use common.fixtures module#15904RaphaelRheault wants to merge 1 commit into
RaphaelRheault wants to merge 1 commit into
Conversation
watilde
approved these changes
Oct 6, 2017
BridgeAR
reviewed
Oct 9, 2017
Member
There was a problem hiding this comment.
There is the fixtures.path function for this and it would be nice to use that instead.
joyeecheung
reviewed
Oct 11, 2017
Member
There was a problem hiding this comment.
Can you change this to const expected = fixtures.path('cycles', 'root.js')?
Member
There was a problem hiding this comment.
Can you change this to const expected = fixtures.path('cycles', 'folder')?
Member
|
Ping @RaphaelRheault |
Contributor
|
Hi @RaphaelRheault, would you like to follow up on this so that it can land? A few small changes were requested above — let me know if you need any pointers. Thanks for helping us improve Node! |
Member
|
I fixed the nits and force-pushed. This should be good to go. PTAL. CI: https://ci.nodejs.org/job/node-test-pull-request/11057/ |
tniessen
approved these changes
Oct 28, 2017
Member
|
Landed in 6ff2909, thank you! 🎉 |
tniessen
pushed a commit
that referenced
this pull request
Oct 28, 2017
PR-URL: #15904 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
PR-URL: #15904 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
PR-URL: #15904 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
gibfahn
pushed a commit
that referenced
this pull request
Oct 31, 2017
PR-URL: #15904 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
PR-URL: nodejs/node#15904 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
PR-URL: nodejs/node#15904 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
PR-URL: #15904 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15904 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15904 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#15904 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done at Code & Learn for Node.js Interactive Vancouver
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)