Skip to content

test: delete outdated fixtures/stdio-filter.js#13712

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:x-test-stdio-filter
Closed

test: delete outdated fixtures/stdio-filter.js#13712
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:x-test-stdio-filter

Conversation

@vsemozhetbyt

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

I cannot find where this file is used. Please, correct me if I miss something.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 16, 2017
@vsemozhetbyt

Copy link
Copy Markdown
Contributor Author

@Trott Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green

@mscdex

mscdex commented Jun 16, 2017

Copy link
Copy Markdown
Contributor

LGTM

@vsemozhetbyt

Copy link
Copy Markdown
Contributor Author

Landed in aaa80df

@vsemozhetbyt vsemozhetbyt deleted the x-test-stdio-filter branch June 18, 2017 23:31
vsemozhetbyt added a commit that referenced this pull request Jun 18, 2017
PR-URL: #13712
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
addaleax pushed a commit that referenced this pull request Jun 20, 2017
PR-URL: #13712
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@addaleax addaleax mentioned this pull request Jun 21, 2017
addaleax pushed a commit that referenced this pull request Jun 21, 2017
PR-URL: #13712
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@addaleax addaleax mentioned this pull request Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants