Skip to content

deps: float patch on npm to fix citgm#13305

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:npm-patch
Closed

deps: float patch on npm to fix citgm#13305
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:npm-patch

Conversation

@MylesBorins

@MylesBorins MylesBorins commented May 30, 2017

Copy link
Copy Markdown
Contributor

This floats npm/npm#16791 onto npm v5.0.0
to fix an edge case that was found in citgm

/cc @zkat

@MylesBorins MylesBorins requested a review from jasnell May 30, 2017 16:24
@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label May 30, 2017
zkat
zkat approved these changes May 30, 2017
View reviewed changes

@zkat zkat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ligtum

zkat
zkat approved these changes May 30, 2017
View reviewed changes

@zkat zkat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ligtum

@jasnell

jasnell commented May 30, 2017

Copy link
Copy Markdown
Member

FYI... @nodejs/ctc This is needed for the 8.0.0 release today and must be fast tracked.

@jasnell

jasnell commented May 30, 2017

Copy link
Copy Markdown
Member

@MylesBorins ... would you be able to kick off a quick citgm run on OSX to verify that this fixes the issue?

@jasnell

jasnell commented May 30, 2017

Copy link
Copy Markdown
Member

@MylesBorins ... nevermind :-) ... I kicked one off https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/847/

@MylesBorins
deps: float patch on npm to fix citgm
363b938 
This floats npm/npm#16791 onto npm v5.0.0
to fix an edge case that was found in citgm
@MylesBorins

MylesBorins commented May 30, 2017

Copy link
Copy Markdown
Contributor Author

I can verify that the patch fixes citgm on osx... tested on local machine

jasnell pushed a commit that referenced this pull request May 30, 2017
@MylesBorins @jasnell
deps: float patch on npm to fix citgm
d985ca7 
This floats npm/npm#16791 onto npm v5.0.0
to fix an edge case that was found in citgm

PR-URL: #13305
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
jasnell pushed a commit that referenced this pull request May 30, 2017
@MylesBorins @jasnell
deps: float patch on npm to fix citgm
a85b48c 
This floats npm/npm#16791 onto npm v5.0.0
to fix an edge case that was found in citgm

PR-URL: #13305
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@MylesBorins

MylesBorins commented May 30, 2017

Copy link
Copy Markdown
Contributor Author

landed in a85b48c

@refack

refack commented May 30, 2017

Copy link
Copy Markdown
Contributor

This solves the citgm.underscore-vundefined undefined issue?

@refack refack mentioned this pull request May 30, 2017
Closed
3 tasks
@refack

refack commented May 30, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Confirmed on aix
before: error: express done | done - the test suite for express version undefined failed
after info: express done | done - the test suite for express version 4.15.3 passed.
(also no Unexpected end of JSON input)

@MylesBorins

MylesBorins commented May 31, 2017

Copy link
Copy Markdown
Contributor Author

@refack yeah... sorry for not documenting that

@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@MylesBorins MylesBorins deleted the npm-patch branch November 14, 2017 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

+2 more reviewers

@zkat zkat zkat approved these changes

@evanlucas evanlucas evanlucas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@MylesBorins @jasnell @refack @zkat @evanlucas @cjihrig @nodejs-github-bot