doc: corrected vcbuild parameters for testing on windows

[jboarman]

Checklist

• make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

doc

Description of change

Corrected parameter for running tests on Windows. Without the corrected
parameters, Windows users encounter an error about failing to sign the
build, "Failed to sign exe", which can be discouraging to new Windows
community members.

[Trott]

@nodejs/platform-windows

[seishun]

LGTM, although I'd prefer vcbuild nosign test.

[gibfahn]

I think this would be made unnecessary by #10156, which will also stop people having to remember the nosign argument.

[jasnell]

#10156 landed. Is this still necessary?

[gibfahn]

@jasnell #10156 was semver-major, so I guess it still makes sense to do this for v[7,6,4]?

+1 for vcbuild test nosign->vcbuild nosign test

I'd also prefer changing .\vcbuild -> vcbuild for consistency (also on the build line above).

EDIT: we should be using .\vcbuild as per @richardlau's comment

cc/ @joaocgreis

[richardlau]

@gibfahn .\vcbuild works on both cmd.exe and PowerShell on Windows (vcbuild does not work on PowerShell, see #8704).

[joaocgreis]

LGTM for v[4,6,7].

[jasnell]

If this is a backport for 7, 6 and 4, then, separate PRs for landing in those should be opened.

[jboarman]

I'm thinking that #10156 now makes this PR un-necessary.

[gibfahn]

@jboarman see #10112 (comment), it's necessary for all current release lines as that PR is semver-major.