Fix map handling in .js and .codec.js to match .base.js#1
Closed
roncli wants to merge 1 commit into
Closed
Conversation
The map handling in msgpack.js and msgpack.codec.js only handled element keys which were of type 0xa0. This meant any map elements whose key was not a string of 31 bytes or less would not be imported correctly. msgpack.base.js handles element keys correctly, however, so this commit modifies msgpack.js and msgpack.codec.js to correctly process map keys.
|
this worked for me. Was running into a problem where a property was not decoded with the right name. |
|
Is this project abandoned? |
|
It worked for me . Thank you! |
redboltz
added a commit
to redboltz/msgpack-javascript
that referenced
this pull request
Feb 15, 2015
Any msgpack object can be map's key now. This fix is the same as follows: msgpack#1 The source repository of the pull request seems to be lost, so I created the same fix.
|
Please merge this commit, works well |
gfx
pushed a commit
that referenced
this pull request
Aug 10, 2021
* Bump actions/setup-node from 1 to 2.4.0 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 1 to 2.4.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v1...v2.4.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Update .github/workflows/ci.yml * Update .github/workflows/fuzz.yml * Update .github/workflows/ci.yml * Update ci.yml * Update fuzz.yml Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The map handling in msgpack.js and msgpack.codec.js only handled
element keys which were of type 0xa0. This meant any map elements
whose key was not a string of 31 bytes or less would not be imported
correctly. msgpack.base.js handles element keys correctly, however, so
this commit modifies msgpack.js and msgpack.codec.js to correctly
process map keys.