Skip to content

Remove the Map.prototype.getOrInsertComputed polyfill from the scripting implementation (PR 21399 follow-up) - #21405

Merged
calixteman merged 1 commit into
mozilla:masterfrom
Snuffleupagus:scripting-rm-getOrInsertComputed-polyfill
Jun 8, 2026
Merged

Remove the Map.prototype.getOrInsertComputed polyfill from the scripting implementation (PR 21399 follow-up)#21405
calixteman merged 1 commit into
mozilla:masterfrom
Snuffleupagus:scripting-rm-getOrInsertComputed-polyfill

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

All unit- and integration-tests pass with this patch, and according to the QuickJS changelog this is supported now; note https://github.com/bellard/quickjs/blob/3d5e064e9dd67c70f7962836505a7fa067bf0a4e/Changelog#L10 and https://github.com/tc39/proposal-upsert.

…pting implementation (PR 21399 follow-up)

All unit- and integration-tests pass with this patch, and according to the QuickJS changelog this is supported now; note https://github.com/bellard/quickjs/blob/3d5e064e9dd67c70f7962836505a7fa067bf0a4e/Changelog#L10 and https://github.com/tc39/proposal-upsert.
@codecov-commenter

codecov-commenter commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (52a44a6) to head (5f83408).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21405      +/-   ##
==========================================
- Coverage   89.66%   89.66%   -0.01%     
==========================================
  Files         260      260              
  Lines       66010    66010              
==========================================
- Hits        59188    59187       -1     
- Misses       6822     6823       +1     
Flag Coverage Δ
browsertest 66.75% <ø> (ø)
fonttest 9.02% <ø> (ø)
integrationtest 66.77% <ø> (-0.01%) ⬇️
unittest 57.12% <ø> (+0.01%) ⬆️
unittestcli 56.05% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus
Snuffleupagus marked this pull request as ready for review June 8, 2026 10:45
@Snuffleupagus
Snuffleupagus requested a review from calixteman June 8, 2026 10:59

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman
calixteman merged commit ea4fe68 into mozilla:master Jun 8, 2026
26 of 31 checks passed
@Snuffleupagus
Snuffleupagus deleted the scripting-rm-getOrInsertComputed-polyfill branch June 8, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants