Remove the Map.prototype.getOrInsertComputed polyfill from the scripting implementation (PR 21399 follow-up) - #21405
Merged
calixteman merged 1 commit intoJun 8, 2026
Conversation
…pting implementation (PR 21399 follow-up) All unit- and integration-tests pass with this patch, and according to the QuickJS changelog this is supported now; note https://github.com/bellard/quickjs/blob/3d5e064e9dd67c70f7962836505a7fa067bf0a4e/Changelog#L10 and https://github.com/tc39/proposal-upsert.
Snuffleupagus
temporarily deployed
to
code-coverage
June 8, 2026 09:51 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
June 8, 2026 09:51 — with
GitHub Actions
Inactive
Snuffleupagus
had a problem deploying
to
code-coverage
June 8, 2026 09:51 — with
GitHub Actions
Error
Snuffleupagus
had a problem deploying
to
code-coverage
June 8, 2026 09:51 — with
GitHub Actions
Error
Snuffleupagus
had a problem deploying
to
code-coverage
June 8, 2026 09:51 — with
GitHub Actions
Error
Snuffleupagus
temporarily deployed
to
code-coverage
June 8, 2026 09:51 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
June 8, 2026 09:51 — with
GitHub Actions
Inactive
Snuffleupagus
had a problem deploying
to
code-coverage
June 8, 2026 09:51 — with
GitHub Actions
Error
Snuffleupagus
temporarily deployed
to
code-coverage
June 8, 2026 09:51 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
June 8, 2026 09:51 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
June 8, 2026 09:51 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
June 8, 2026 09:51 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
June 8, 2026 09:51 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
June 8, 2026 09:51 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
June 8, 2026 09:51 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
June 8, 2026 09:51 — with
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21405 +/- ##
==========================================
- Coverage 89.66% 89.66% -0.01%
==========================================
Files 260 260
Lines 66010 66010
==========================================
- Hits 59188 59187 -1
- Misses 6822 6823 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Snuffleupagus
temporarily deployed
to
code-coverage
June 8, 2026 10:15 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
June 8, 2026 10:15 — with
GitHub Actions
Inactive
Snuffleupagus
had a problem deploying
to
code-coverage
June 8, 2026 10:15 — with
GitHub Actions
Failure
Snuffleupagus
temporarily deployed
to
code-coverage
June 8, 2026 10:15 — with
GitHub Actions
Inactive
Snuffleupagus
marked this pull request as ready for review
June 8, 2026 10:45
Snuffleupagus
temporarily deployed
to
code-coverage
June 8, 2026 10:45 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All unit- and integration-tests pass with this patch, and according to the QuickJS changelog this is supported now; note https://github.com/bellard/quickjs/blob/3d5e064e9dd67c70f7962836505a7fa067bf0a4e/Changelog#L10 and https://github.com/tc39/proposal-upsert.