Repository navigation
feat: add UpdateChecklistItem gadget and improve agent workflow - #5
Merged
Merged
Conversation
- Add UpdateChecklistItem gadget for marking acceptance criteria complete - Add cardUrl to agent context for Trello links in PR descriptions - Update briefing prompts to create dependency checklists (🔗 Dependencies) - Update implementation prompts with structured PR format and completion process - Extract and return PR URL from agent output - Move card to IN PROGRESS list when implementation starts 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This was referenced Feb 17, 2026
This was referenced Mar 10, 2026
zbigniewsobiecki
added a commit
that referenced
this pull request
Apr 15, 2026
…Save All 11 per-plan ACs pass. Spec ACs #5-8 delivered: - Linear upsert succeeds on fresh projects and re-configuration - DB error diagnostics (SQLSTATE, constraint, detail) surface in server logs - tRPC clients receive generic 'Internal server error' for unexpected throws - Plaintext credentials never leak into captured stdout/stderr Caveat: CLAUDE.md addition deferred to avoid conflicting with the user's in-progress rewrite of that file. Doc impact met via CHANGELOG. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
zbigniewsobiecki
added a commit
that referenced
this pull request
Apr 15, 2026
* docs(plans): add spec 002 and plans; lock plan 002/1
Spec 002 (linear-webhook-setup-ux) introduces the Linear wizard UX
improvements and save-path fix. Plan 1 locked for execution.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* feat(dashboard): structured error logging for tRPC + Hono
Adds src/api/errorLogging.ts with formatters that surface pg driver
fields (code, detail, constraint, table) onto server-side logs for
both Hono app.onError and the tRPC errorFormatter. Client responses
for INTERNAL_SERVER_ERROR now carry a generic message; real details
remain in cascade-dashboard-* stdout for operators to grep.
plan 002/1 task 1.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(db): allow provider=linear under category=pm in integration check constraint
The chk_integration_category_provider check constraint (from
0047_add_alerting_integration.sql) only permitted trello/jira for
pm-category integrations. Linear support was introduced without a
matching constraint update, so every projects.integrations.upsert
for category=pm + provider=linear failed with SQLSTATE 23514 and
surfaced as HTTP 500 from the dashboard Linear wizard.
Migration 0049 drops and re-creates the constraint with linear added
to the pm branch. Forward-only, no data migration required.
Reproduced with two new integration tests against the test DB.
plan 002/1 tasks 2-3 (diagnose + fix).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* test(api): assert plaintext credentials never leak into server logs
Integration tests that spy on console.{log,error,warn} around
writeProjectCredential, upsertProjectIntegration (happy + FK-violation
paths), and the formatTRPCErrorLog formatter. Asserts the sentinel
credential value never appears in captured output, while confirming
the real PG error (SQLSTATE + constraint name) IS present on the
failure path — proving diagnosability without leakage.
plan 002/1 task 4.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* docs(plans): plan 002/1 (save-path-fix) done — unblock Linear wizard Save
All 11 per-plan ACs pass. Spec ACs #5-8 delivered:
- Linear upsert succeeds on fresh projects and re-configuration
- DB error diagnostics (SQLSTATE, constraint, detail) surface in server logs
- tRPC clients receive generic 'Internal server error' for unexpected throws
- Plaintext credentials never leak into captured stdout/stderr
Caveat: CLAUDE.md addition deferred to avoid conflicting with the
user's in-progress rewrite of that file. Doc impact met via CHANGELOG.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* docs(plans): update plan 002/1 progress checkboxes to done
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* docs(plans): lock plan 002/2 + record testing-approach divergence
Plan 2 originally assumed @testing-library/react in web/; project has no
such infrastructure and the web/ package has no test script. Plan edited
in place to:
- use react-dom/server.renderToStaticMarkup (available; no new deps)
- test under the existing root unit-core project
- drop interactive-mutation tests (would need jsdom); ProjectSecretField
internals are out-of-scope per spec non-goal
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* docs(plans): plan 002/2 frontmatter status -> wip
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* feat(dashboard): linear wizard UX — accurate events list and inline signing secret
Plan 002/2 (wizard-webhooks-step).
Linear PM wizard Webhooks step now:
- lists the three event families CASCADE consumes (Issues, Comments,
Issue Labels), each with a one-line rationale tracing to
src/triggers/linear/
- renders a ProjectSecretField bound to LINEAR_WEBHOOK_SECRET directly
beneath the webhook URL, matching the Sentry alerting tab pattern
- drops the 'store as LINEAR_WEBHOOK_SECRET in project credentials'
trailing bullet (replaced by the inline input)
PMWizard threads projectId + the masked LINEAR_WEBHOOK_SECRET credential
meta from projects.credentials.list through WebhookStep, so the field
reflects its own stored value on mount and stays in sync with the
Credentials tab.
Tests: 17 new SSR tests using react-dom/server — no React testing
library required. Interactive mutation firing is out of scope (would
need jsdom); ProjectSecretField itself is untested today under the
same constraint and is spec non-goal to modify.
vitest.config.ts gains @/components, @/lib, @/hooks aliases pointing at
web/src/ for test-time resolution.
src/integrations/README.md Linear section defers to the dashboard
wizard as the authoritative setup source.
Plan 2 closes out spec 002.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* docs(claude): streamline CLAUDE.md to essentials
Compacts the project's CLAUDE.md from ~820 to ~163 lines by dropping
dated setup minutiae, duplicated process docs, and legacy sections.
Keeps the load-bearing context: architecture, PR checkout gotcha,
testing commands, Zod policy, migrations, GitHub dual-persona rules,
trigger system, engines, environment, and git hooks.
No code changes.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 of 3 tasks
zbigniewsobiecki
added a commit
that referenced
this pull request
Apr 16, 2026
Closes plan 006/5 — the final cleanup plan of spec 006. Backend: - src/integrations/bootstrap.ts — DELETED. PM registrations flow through src/integrations/pm/index.ts (which also mirrors manifests into integrationRegistry). SCM (GitHub) and alerting (Sentry) self-register via new side-effect modules. - src/github/register.ts + src/sentry/register.ts — new minimal side-effect modules that replace the respective branches of the deleted bootstrap. SCM + alerting stay on the legacy IntegrationModule pattern (out of spec 006 scope). - src/pm/registry.ts — converted to a read-only adapter over pmProviderRegistry. get/getOrNull/all/createProvider/ resolveLifecycleConfig all delegate to the manifest registry. register() is a deprecation warn. The ~9 unmigrated call sites (webhook handlers, manual runner, credential scope, lifecycle, GitHub adapter) keep working unchanged — they now transparently read from the manifest registry, so there is no divergent registration. - src/router/index.ts + src/worker-entry.ts — updated to import the three new side-effect modules instead of the deleted bootstrap. - src/integrations/registry.ts — header comment updated to reflect the new population topology. Tests: - tests/unit/integrations/bootstrap.test.ts — rewritten to cover the new side-effect-module wiring (the file name stays for audit clarity; its content asserts the same end-state invariants). - 8 other test files that imported bootstrap.js for side effect are migrated to import the three new modules (pm barrel + github/register + sentry/register). Docs: - src/integrations/README.md — rewritten. Transitional note + "Legacy path" section removed. The README is now the single canonical author's guide for adding a new PM provider. - CLAUDE.md — integration-abstraction pointer updated to final state. - CHANGELOG.md — entry per plan. Plan-divergence: - AC #2 (delete pm/registry.ts) — became: convert to a read-only delegate. Deleting it would require migrating 9 call sites that are out of spec scope. The delegate preserves the end state (single source of truth = pmProviderRegistry) without downstream churn. - AC #5 (consolidate createXxxLabel tRPC endpoints) — deferred to a follow-up PR. Purely additive cleanup; not required for any spec AC. Both divergences documented in the .done plan. Tests: 7809/7809 pass. Build + lint + typecheck clean. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 of 2 tasks
zbigniewsobiecki
added a commit
that referenced
this pull request
Apr 25, 2026
…tructured envelope, --comment alias) (#1190) * docs(014): spec + plans for cascade-tools agent ergonomics Adds docs/specs/014-cascade-tools-agent-ergonomics.md plus two plans covering shared-infra and create-pr-review adoption. Prompted by prod run 5d993b04-6e05-4ae1-b7de-8c274cf3496b. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(plan-014): lock plan 1 (shared-infra) * feat(cascade-tools): plan 014/1 shared-infra — truthful prompts + envelope Ships the root-cause fix for prod run 5d993b04-6e05-4ae1-b7de-8c274cf3496b plus the shared infrastructure every future gadget inherits: - System-prompt renderer (src/backends/shared/nativeToolPrompts.ts) stops stripping trailing 's' from array param names and claiming '<string> (repeatable)' for every array. Array-of-object params now render as `--<flag> '<json>'` with aliases appended via `|` and a one-line runnable example from the tool definition. - Factory (src/gadgets/shared/cliCommandFactory.ts) gains oclif flag aliases, JSON parsing for array-of-object flags, file-input JSON parsing, `examples` wired into oclif `--help`, and Levenshtein-based 'did you mean' suggestions for mistyped flags (via fastest-levenshtein). - New shared error envelope (src/gadgets/shared/errorEnvelope.ts) — every CLI failure emits `{"success":false,"error":{type,flag?,message,got?, expected?,hint?,example?}}` on stdout plus a one-line prose summary on stderr. All prior `this.error()` / flat `{success:false,error:"<string>"}` call sites migrated. - Contracts widened: ParameterDefinition gains `cliAliases`, FileInput- Alternative gains `parseAs`, ToolManifest parameters carry `items`, `aliases`, `example`. - Manifest generator threads the new fields through. - bin/cascade-tools.js wraps `run()` to swallow oclif ExitError cleanly so the envelope isn't obscured by Node's default stack dump. Plan-1 ACs #1–#17 all delivered. 8438/8438 unit tests passing. Test surface delta: 57 new unit tests across errorEnvelope.test.ts, shared-nativeToolPrompts.test.ts, and factories.test.ts. Seven legacy assertions encoding the pre-014 error surface updated in cli/cli-command- factory, cli/file-input-flags, cli/scm/create-pr-sidecar, cli/scm/create- pr-review-sidecar, backends/claude-code. Plan 2 adopts the pattern on createPRReviewDef — zero shared-file edits — proving the declarative-metadata invariant. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(plan-014): lock plan 2 (createprreview-adopt) * feat(cascade-tools): plan 014/2 createprreview-adopt + spec done Applies the spec-014 declarative-metadata pattern to createPRReviewDef: - --comment alias for --comments (the exact muscle-memory mistake from prod run 5d993b04-6e05-4ae1-b7de-8c274cf3496b). - --comments-file <path> (and - for stdin) JSON-parsed escape hatch for long payloads that don't survive shell quoting. - Two declarative fields on createPRReviewDef.parameters.comments.cliAliases + createPRReviewDef.cli.fileInputAlternatives. Zero edits to shared infrastructure (cliCommandFactory, manifestGenerator, nativeToolPrompts, errorEnvelope) — proves spec 014's single-entrypoint invariant. Per-plan ACs #1, #2, #3, #5, #6, #7, #8, #9, #11, #12 auto-verified (unit tests + build + lint + typecheck). AC #4 (binary-level smoke) tagged [manual] because vitest fork-pool workers fail to capture stdout/stderr from spawned binaries that do top-level await import(); the six scenarios were verified manually against the built binary and the trace is recorded in the plan. AC #10 n/a — integration test path abandoned for the same reason. All plans done. Spec 014 marked .done (docs/specs/014-*.md → .done). CHANGELOG Unreleased updated with a per-plan entry. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Jun 24, 2026
zbigniewsobiecki
added a commit
that referenced
this pull request
Aug 25, 2026
… 5/5) (#1546) Spec 024's final plan. Shared board and repository topologies are now configurable by an operator rather than only through the API, which is what the README's 'do not configure this in production' caveat had been waiting on since plan 2. - JIRA wizard 'Team routing' step: discriminator kind + value, optional and empty by default. 'None' is a legitimate choice — a key may have exactly one project without a discriminator, and that project is its default owner. - SCM tab 'Repository role': primary/secondary, sent only when the operator touches it, so an unrelated save leaves a shared repository's topology alone. - Operator walkthrough for both topologies, replacing the caveat. Three review rounds, four must-fixes. The first invalidated the plan's premise: cascade-tools rebuilds its project from env vars and the discriminator was not among them, so stamping and JQL scoping silently no-opped inside every worker — an agent's own work items routed to the wrong project. Round 2 found a second, near-identical synthesizer in the friction gadget on the default engine path. Both now share src/jira/config-from-env.ts with a static guard, because a third copy would have guaranteed an eleventh instance of that drift class. 27 new tests; 11207 passing; typecheck clean in both workspaces. AC #5 is deferred, not done: its manual protocol needs a live dev API. Round 1 found a real UX defect in exactly that surface, and a follow-up commit found it was still reachable on the edit path — treat visual placement as unverified. Marks spec 024 done: five plans, thirteen review rounds.
bychkov
pushed a commit
to bychkov/cascade
that referenced
this pull request
Sep 26, 2026
…(spec 021 plan 3) The additive admin side of multi-org membership (spec 021, plan 3 of 4): an admin of an org (or a superadmin) can grant an existing email a membership in their org with a per-org role, creating a user with an already-registered email returns a clear CONFLICT instead of a 500, and listing an org returns its true membership — including accounts whose home org is elsewhere. - addExistingUserToOrg grant mutation: org-admin/superadmin only (refined by the per-org actor role), NOT_FOUND when no account owns the email, idempotent re-grant (upsert updates the per-org role). - Graceful duplicate-email create: catch the Postgres unique violation (23505, unwrapped from drizzle's DrizzleQueryError cause) and map it to a typed CONFLICT whose message distinguishes "already a member here" from "account exists — add to this org". - createUserWithMembership: create mirrors a membership in the same transaction so new accounts appear in the membership-based listing; a duplicate email rolls back without an orphan membership. - listOrgMembers: membership-based listing joining org_memberships -> users with the per-org role; excludeGlobalRole keeps regular admins from seeing global superadmins. - CLI parity: new `cascade users add-to-org`, membership-based `list`, and clean conflict messaging on `create`. Satisfies spec ACs mongrel-intelligence#1 (add existing account) and mongrel-intelligence#2 (no more 500); mongrel-intelligence#5 partial (membership listing API; UI render is plan 4). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
bychkov
pushed a commit
to bychkov/cascade
that referenced
this pull request
Sep 26, 2026
…ember list Spec 021 plan 4 (MNG-1674): the user-facing layer over the curl-testable backend from plans 2-3 (web/ only). - Active-org switcher (sidebar) for non-superadmin multi-org members, backed by auth.listMyOrgs + auth.setActiveOrg; invalidates every query on switch so the dashboard refetches against the new active org. Single-org users get an inert org-name banner (spec AC mongrel-intelligence#9). Superadmin cross-org switching via x-org-context is unchanged (spec AC mongrel-intelligence#7). - Add-existing-account dialog on Settings → Users calling users.addExistingUserToOrg, surfacing the NOT_FOUND envelope inline; the complementary CONFLICT from users.create is already shown inline by the create dialog (spec AC mongrel-intelligence#1). - Member list now renders per-org role alongside the account role plus a Guest badge for cross-home members (spec AC mongrel-intelligence#5). Pure helpers (shouldShowOrgSwitcher, resolveActiveOrgName, formatAddToOrgSuccess, describeMemberRow) and SSR-safe presentational components (OrgSwitcherView, AddToOrgForm) are unit-tested; hook-wired containers are thin. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ability for agents to mark acceptance criteria as complete and improves the implementation agent workflow with better PR descriptions and completion processes.
Changes
--fillflagTesting
Related
🤖 Generated with Claude Code