Remove PackageLicenseFile preventing PackageLicenseExpression from working

[lahma]

Description

Removing the PackageLicenseFile allows PackageLicenseExpression to work correctly. Adding explicit packaging instructions to nuspec to keep the MIT license as part of packages.

Checking artifacts from .\build.cmd -pack

Before

After

Related issue

fixes #4816

• I have ensured that there is a previously discussed and approved issue.

[lahma]

@microsoft-github-policy-service agree

[lahma]

With the proposed changes the package verification now fails.

[Evangelink]

Yes because there are less files included. Let me help you here.

[Evangelink]

Example when building locally Microsoft.NET.Test.Sdk

[lahma]

My assumption was that the license file should part of the package even though license expression would be MIT, this is why added explicit packaging. So should the checks just be changed to have one file less as expected count?

[Evangelink]

For all packages using MIT license, reduce count by 1 as license file is no longer present.

[Evangelink]

My assumption was that the license file should part of the package even though license expression would be MIT, this is why added explicit packaging.

File was added explicitly because VSTest was only moved to our common build infra recently and there are still reminicense of the past that we missed.

So should the checks just be changed to have one file less as expected count?

Correct! I did it and checked locally that build was good.

--

Thanks for the contribution @lahma!

[Evangelink]

Hum that's weird. I am pretty busy until Thursday so I will only be able to investigate and ensure this gets merged then.

Sorry for the delay!

[Evangelink]

Still working out what's the issue.

[Evangelink]

Ok so that was just the test infra being super flaky.

Thank you for the work here @lahma!