Skip to content

Snapcraft update. Fixes #63194 Fixes #57019 - #70884

Merged
João Moreno (joaomoreno) merged 12 commits into
microsoft:masterfrom
Wimpressive-Snaps:snapcraft-update
Mar 25, 2019
Merged

Snapcraft update. Fixes #63194 Fixes #57019#70884
João Moreno (joaomoreno) merged 12 commits into
microsoft:masterfrom
Wimpressive-Snaps:snapcraft-update

Conversation

@flexiondotorg

@flexiondotorg Martin Wimpress (flexiondotorg) commented Mar 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request refactors the snapcraft.yaml and its associated electron-launch wrapper to address two bugs for the Linux snap package.

@flexiondotorg
electron-launch: Use bash
16a06ac
@flexiondotorg
electron-launch: Correctly map the /snap directory on Fedora
22dc561
@flexiondotorg
electron-launch: Add architecture detection
07f2bdc
@flexiondotorg
electron-launch: Create $XDG_CACHE_HOME
c8493b4 
Relocate $XDG_CACHE_HOME within the snaps common user data.
@flexiondotorg
electron-launch: ABI compatible GDK PixBuf modules
04639e4 
Use ABI compatible GDK PixBuf modules from within the snap and build gdk-pixbuf-loaders.cache in the snaps common user data.
@flexiondotorg
snapcraft.yaml: Add the GNOME 3.26 PPA.
e91b073 
Adds the PPA for the GNOME 3.26 framework which is maintained by the Ubuntu Desktop team.

This PPA includes GTK3 and GNOME3 components used to create the GNOME 3.26 Framework snap for Ubuntu 16.04.

  * Fixes:  #63194
  * Fixes:  #57019
@flexiondotorg
snapcraft.yaml: Update stage-packages
c134334 
Clean up the stage-packages: to drop any unnecessary libraries and ensure all required libraries to maintain ABI compatibility are bundled in the snap.
@flexiondotorg
snapcraft.yaml: Remove unnecessary data from the snap
73b7ed5
@flexiondotorg
snapcraft.yaml: Remove braces from ${SNAP} in command:
e07c331
@flexiondotorg
snapcraft.yaml: Fallback to XWayland if running in a Wayland session
d5c14c6
@flexiondotorg
snapcraft.yaml: Source Glib schemas from within the snap.
7f9406d
@flexiondotorg
snapcraft.yaml: Add the url-handler
24e592c
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Mar 21, 2019 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@flexiondotorg Martin Wimpress (flexiondotorg) changed the title Snapcraft update. Fixes #63194 Fixes Snapcraft update. Fixes #63194 Fixes #57019 Mar 21, 2019
@joaomoreno João Moreno (joaomoreno) added this to the March 2019 milestone Mar 21, 2019
@joaomoreno João Moreno (joaomoreno) added install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux snap Issues related to the snap package labels Mar 21, 2019
@joaomoreno

João Moreno (joaomoreno) commented Mar 25, 2019

Copy link
Copy Markdown
Contributor

Works like a charm Martin Wimpress (@flexiondotorg)! Thanks a lot! 🎆

@joaomoreno
João Moreno (joaomoreno) merged commit fd77ea1 into microsoft:master Mar 25, 2019
This was referenced Mar 25, 2019
Closed
Closed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@joaomoreno João Moreno (joaomoreno)

Labels

install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux snap Issues related to the snap package

Projects

None yet

Milestone

March 2019

Development

Successfully merging this pull request may close these issues.

3 participants

@flexiondotorg @msftclas @joaomoreno