Skip to content

debugger console recognizes italic ansi code - #67511

Merged
Isidor Nikolic (isidorn) merged 13 commits into
microsoft:masterfrom
flurmbo:debug-console-ansi-italics
Mar 4, 2019
Merged

Isidor Nikolic (isidorn) merged 13 commits into
microsoft:masterfrom
flurmbo:debug-console-ansi-italics

Conversation

@flurmbo

Copy link
Copy Markdown
Contributor

Fixes #67510

@isidorn

Copy link
Copy Markdown

Thanks for your PR. Not for endgame, will review once I am back from vacation in 2 weeks

@isidorn

Copy link
Copy Markdown

This looks good.
Phil Marshall (@flurmbo) in order to merge this in can you please:

  1. resolve the confilicts
  2. test that it works in latest
  3. write unit tests that cover your case. Here's a pointer https://github.com/Microsoft/vscode/blob/f6caa53cdd87f3fcee7de78d6a5b60a6835cde29/src/vs/workbench/contrib/debug/test/browser/debugANSIHandling.test.ts#L1

@flurmbo

Copy link
Copy Markdown
Contributor Author

Isidor Nikolic (@isidorn) sure I'll try to get to it in the next few days!

@flurmbo

Copy link
Copy Markdown
Contributor Author

Hey Isidor Nikolic (@isidorn) I made the changes you asked for, let me know what you think!

@isidorn

Copy link
Copy Markdown

Thanks a lot. This week we are in endgame which means we only bugfix and take limited changes. Due to that I am assigning this to march and I will probably review next week.

@isidorn

Isidor Nikolic (isidorn) commented Mar 4, 2019 •

Copy link
Copy Markdown

Phil Marshall (@flurmbo) great work, merging this in. Nice tests
Thanks a lot!

@isidorn
Isidor Nikolic (isidorn) merged commit 5b324d0 into microsoft:master Mar 4, 2019
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debug console does not support italic ANSI escape sequence

2 participants