Fixes Git Clone Problem with Spaces

[Scott Craig (scottymcraig)]

Fixes #60472. Checks to see if there are spaces in the URL and if so, encodes them.

[Vikas Kumar Yadav (ctrlaltvikas)]

Looks good Scott Craig (@scottymcraig)

[Peter Wone (PeterWone)]

I realise my bug report describes spaces, but having seen the fundamental problem (the name can contain characters not allowed in a file path) surely you would fix it like this
await this.exec(parentPath, ['clone', encodeURI(url), folderPath], { cancellationToken });
rather than this proposed solution
await this.exec(parentPath, ['clone', url.includes(' ') ? encodeURI(url) : url, folderPath], { cancellationToken });
which specifically addresses spaces.

[Scott Craig (scottymcraig)]

Because encoding a string that already has encoding can cause it to be re-encoded. We just simply want to catch the cases where it comes from Azure DevOps with the spaces. None of the other cloning urls are having problems.

[Peter Wone (PeterWone)]

Yes and I've just checked, Azure DevOps won't allow any other toxic characters. Just being paranoid! :)

[Jithil P Ponnan (MrJithil)]

we don't really need to check whether the url contains a space. It will be more better, if we are encoding the url even if it is not contains a space.

[Scott Craig (scottymcraig)]

Jithil P Ponnan (@MrJithil) We can't do that - see my comment above Peter's

[Glober777]

Can't wait for this issue to be fixed :)

[João Moreno (joaomoreno)]

Thought exactly the same as Peter Wone (@PeterWone) but I do like the reasoning from Scott Craig (@scottymcraig).

Thanks for the fix!