Repository navigation
chat: Anchor Add Context picker to its button - #338924
Merged
Megan Rogge (meganrogge) merged 6 commits intoSep 30, 2026
Merged
Conversation
Keep the existing centered quick pick for the classic composer layout while anchoring it to the attach button in the experimental layout. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Megan Rogge (meganrogge)
September 30, 2026 16:21
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The behavior is correctly scoped, preserves the classic layout, and has focused regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Anchors the Attach Context picker to its trigger in the experimental composer while preserving classic centered placement.
Changes:
- Adds optional quick-pick anchoring.
- Tracks the attach button as the anchor.
- Tests both composer layouts.
| File | Description |
|---|---|
newChatContextAttachments.ts |
Supports an optional picker anchor. |
newChatInput.ts |
Anchors only in the experimental layout. |
newChatInput.test.ts |
Covers anchored and centered modes. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Gate anchored Add Context pickers behind a shared experimental setting. New-session composers prefer below the button, while existing chat inputs prefer above it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
2 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: TylerLeonhardtMatched files:
|
Megan Rogge (meganrogge)
enabled auto-merge (squash)
September 30, 2026 16:33
Make Add Context placement consistent without an experimental setting and preserve dropdown semantics by closing the anchored picker when its button is activated again. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the new-session picker alive through repeat button activation so the second click closes it, and add standard spacing between anchored quick inputs and their controls. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 30, 2026
Megan Rogge (meganrogge)
deleted the
merogge/anchor-attach-context-quick-pick
branch
September 30, 2026 19:02
|
This makes using (and suggesting people to use) explicit context attachment 100% better. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #338928
Anchors Add Context to its invoking button across chat inputs:
Validation:
./scripts/test.sh --run src/vs/platform/quickinput/test/browser/quickinput.test.ts --grep "positions an anchored picker below"— passed./scripts/test.sh --run src/vs/sessions/contrib/chat/test/browser/newChatInput.test.ts --grep "context picker"— passednpm run typecheck-client— passed