Repository navigation
fix: memory leak in terminal horizontal scrollbars - #338241
Merged
Dmitriy Vasyura (dmitrivMS) merged 3 commits intoSep 28, 2026
Merged
Dmitriy Vasyura (dmitrivMS) merged 3 commits into
Dmitriy Vasyura (dmitrivMS) merged 3 commits into
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Anthony Kim (@anthonykim1)Matched files:
|
Copilot started reviewing on behalf of
Simon Siefke (SimonSiefke)
September 27, 2026 18:45
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The lifecycle fix is correct and covered by focused regression tests, with only a minor comment-format issue noted.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Fixes retained terminal horizontal scrollbars by removing them from the terminal’s lifetime store when disposed.
Changes:
- Deletes scrollbars through
DisposableStore. - Adds lifecycle and repeated-toggle regression tests.
| File | Description |
|---|---|
terminalInstance.ts |
Corrects scrollbar disposal ownership. |
terminalInstance.test.ts |
Adds scrollbar lifecycle regression coverage. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
Simon Siefke (@SimonSiefke) Thank you! |
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
September 28, 2026 09:16
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 28, 2026
Giuseppe Cianci (Giuspepe)
approved these changes
Sep 28, 2026
Martin Aeschlimann (aeschli)
approved these changes
Sep 28, 2026
Simon Siefke (SimonSiefke)
deleted the
fix/memory-leak-terminalInstance-horizontalScrollbar
branch
September 29, 2026 11:15
Abdon Morales (abdonmorales)
pushed a commit
to abdonmorales/vscode-utcs
that referenced
this pull request
Oct 1, 2026
* fix: release disposed terminal horizontal scrollbars * test: shorten terminal scrollbar sandbox comment --------- Co-authored-by: Dmitriy Vasyura <dmitriv@microsoft.com> (cherry picked from commit 142d5cc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Switching a terminal back from content width removes and disposes its horizontal scrollbar, but leaves the scrollbar in the terminal lifetime store. Repeated toggles keep the old scroll widgets and their DOM state until the terminal closes.
Change
Remove and dispose the scrollbar through the terminal store when content width is disabled and during terminal disposal.
Before
Toggling terminal content width on and off 37 times adds 37 old scroll widgets, their scrollbars, state, and callbacks. The terminal store grows from 2 to 39 discarded scrollbar entries.
After
No more matching scrollbar or scroll-state growth is detected in the same 37-cycle test. The terminal store has no discarded scrollbar entries. Small unrelated DOM-cache and array differences remain in the full heap comparison.
Test Video
Seven content-width toggles on a terminal containing a long line.
test.mp4
AI disclosure: Model: GPT 6 Astra. Worktime: 33 min