Repository navigation
otel: condense late-policy recovery docs - #337588
Closed
Ross Wollman (rwoll) wants to merge 2 commits into
Closed
Ross Wollman (rwoll) wants to merge 2 commits into
Ross Wollman (rwoll) wants to merge 2 commits into
Conversation
Addresses review feedback on #336701: keep the user-visible reload and recovery behavior and drop implementation detail. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Michael Lively (Yoyokrazy)
approved these changes
Sep 23, 2026
Ross Wollman (rwoll)
enabled auto-merge (squash)
September 23, 2026 23:41
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The restart boundary and environment-variable precedence descriptions remain inaccurate.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Condenses OTel activation and recovery documentation around user-visible behavior.
Changes:
- Removes internal implementation details.
- Summarizes reload, restart, identity-denial, and environment-variable behavior.
- Needs clarification that automatic restart applies only when policy first arrives after startup.
- Needs precise wording about environment-variable precedence.
| File | Description |
|---|---|
extensions/copilot/docs/monitoring/agent_monitoring.md |
Simplifies OTel activation and recovery guidance; two documentation clarifications remain. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - `github.copilot.chat.otel.enabled` is `true`, or | ||
| - `github.copilot.chat.otel.dbSpanExporter.enabled` is `true` (the SDK pipeline must be active to feed the SQLite store). | ||
|
|
||
| OTel configuration is read at startup, so most changes need a window reload. Copilot shows a **Reload Window** prompt for them. There is one exception: enterprise policy that turns on OTLP export after Copilot has already started without it. For that case, Copilot restarts the window's extension hosts once per editor session to apply the policy. This also interrupts other extensions. If the restart doesn't apply the policy, Copilot shows a warning with **Reload Window**. An identity-capture denial takes effect for subsequent exports without a reload. |
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
auto-merge was automatically disabled
September 24, 2026 00:06
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to review feedback on #336701 asking whether the late-policy recovery docs could be more concise.
The Activation section now describes only what users and administrators see:
Implementation details are removed: the debounce, the session-ID bookkeeping, the grace period and how the recovery signal is detected. The behavior is unchanged.