Repository navigation
fix: memory leak in extension host speech - #336021
Merged
Dmitriy Vasyura (dmitrivMS) merged 1 commit intoSep 18, 2026
Merged
Dmitriy Vasyura (dmitrivMS) merged 1 commit into
Dmitriy Vasyura (dmitrivMS) merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 18, 2026
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
September 18, 2026 10:36
Collaborator
|
Simon Siefke (@SimonSiefke) Thank you! |
Nick Trogh (ntrogh)
approved these changes
Sep 18, 2026
Henning Dieterichs (hediet)
approved these changes
Sep 18, 2026
Simon Siefke (SimonSiefke)
deleted the
fix/memory-leak-extHostSpeech-lateSession
branch
September 20, 2026 07:39
Abdon Morales (abdonmorales)
pushed a commit
to abdonmorales/vscode-utcs
that referenced
this pull request
Sep 23, 2026
(cherry picked from commit c8103ae)
|
SimonSiefke:fix/memory-leak-extHostSpeech-lateSession |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
If Read Aloud is stopped while a speech provider is still creating its session, cancellation removes the session from the extension host. When the provider finishes, the session is added back to the synthesizer map with no later cancellation to remove it.
Change
Check cancellation after the provider finishes, before storing the synthesizer or subscribing to its events.
Before
When starting and immediately stopping Read Aloud 37 times with a delayed speech provider, 37 extra speech sessions remain in the extension host:
After
No more canceled speech session growth is detected.
Test Video
video.webm