Repository navigation
fix: memory leak in signature help - #336020
Merged
Dmitriy Vasyura (dmitrivMS) merged 2 commits intoSep 18, 2026
Merged
Dmitriy Vasyura (dmitrivMS) merged 2 commits into
Dmitriy Vasyura (dmitrivMS) merged 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
September 18, 2026 09:30
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 18, 2026
Christof Marti (chrmarti)
approved these changes
Sep 18, 2026
Collaborator
|
Simon Siefke (@SimonSiefke) Thank you! |
Nick Trogh (ntrogh)
approved these changes
Sep 18, 2026
Simon Siefke (SimonSiefke)
deleted the
fix/memory-leak-extHostSignatureHelp-cancellation
branch
September 20, 2026 07:39
Abdon Morales (abdonmorales)
pushed a commit
to abdonmorales/vscode-utcs
that referenced
this pull request
Sep 23, 2026
Fix signature help cache leak after cancellation (cherry picked from commit 7828363)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
When signature help is canceled while an extension is still computing its result, the adapter caches the late result. The request has already ended, so that cache entry is never released.
Change
Check cancellation after the provider finishes and return before creating a cache entry.
Before
When requesting and canceling signature help 37 times, the cache grows by 37 signature-help results:
After
No more signature-help cache growth is detected in the same 37-cycle test.
Test Video
signature-video.webm