Repository navigation
add more fun working messages - #335600
Merged
Justin Chen (justschen) merged 4 commits intoSep 18, 2026
Merged
Justin Chen (justschen) merged 4 commits into
Justin Chen (justschen) merged 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments; all reviewers assessed it as ready.
Pull request overview
Expands Chat’s fun working-message pool from 6 to 15 localized Easter-egg phrases.
Changes:
- Adds nine generic, code-themed, and Minecraft-themed messages.
- Updates the localized fun working-message pool.
File summaries
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts |
Adds nine localized fun working messages. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Justin Chen (justschen)
requested changes
Sep 18, 2026
|
|
||
| // Code | ||
| localize('chat.working.fun.code.1', "Consulting the oracle"), | ||
| localize('chat.working.fun.code.2', "Shooting for the stars"), |
Collaborator
There was a problem hiding this comment.
not the biggest fan of shooting for the stars
also we can remove the comment and the line break and just combine the remaining 2 here into the above section.
Justin Chen (justschen)
approved these changes
Sep 18, 2026
Justin Chen (justschen)
enabled auto-merge (squash)
September 18, 2026 17:52
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 18, 2026
roblourens
approved these changes
Sep 18, 2026
Justin Chen (justschen)
merged commit Sep 18, 2026
ee8bba4
into
microsoft:main
52 of 54 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 8 easter-egg phrases to
funWorkingMessages, following up on #313076.Pool goes from 6 to 14.
Phrases approved by Justin Chen (@justschen).