Repository navigation
Ensure managed settings stability with regression tests - #334056
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The gate-state assertion occurs before asynchronous gate computation completes.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/vs/workbench/services/accounts/test/browser/defaultAccount.test.ts — AccountPolicyService computes gateInfo asynchronously: its constructor starts… |
What changed in this PR
Adds managed-settings regression coverage for non-blocking failure scenarios.
Changes:
- Tests outages after successful refreshes.
- Tests malformed refresh controls and non-466 failures.
- Verifies cached policy and freshness preservation.
| File | Description |
|---|---|
src/vs/workbench/services/accounts/test/browser/defaultAccount.test.ts |
Adds managed-settings stability tests. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Don Jayamanne (DonJayamanne)
previously approved these changes
Sep 2, 2026
Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>
Copilot
AI
dismissed
Don Jayamanne (DonJayamanne)’s stale review
via
September 2, 2026 18:33
61ab50d
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 2, 2026
joshspicer
enabled auto-merge (squash)
September 2, 2026 20:25
roblourens
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds regression tests to confirm the stability of managed settings and ensure that no unintended blocking states occur. The following changes were made:
Added Regression Tests: Three new tests were added to
defaultAccount.test.tsto validate the behavior of managed settings under various conditions, including:forceRemoteSettingsRefresh, confirming it does not activate the freshness requirement.Confirmed No Bugs: A thorough review of the managed settings pipeline confirmed that the only way to enter a blocking state is through an explicit
forceRemoteSettingsRefresh: trueor a special HTTP 466 response.Validation: All tests passed successfully, ensuring that the changes do not introduce regressions and that the managed settings functionality remains stable.
This work addresses user concerns about potential regressions and reinforces the stability of the managed settings feature.