Repository navigation
fix: memory leak in notification action view items - #333340
Merged
Dmitriy Vasyura (dmitrivMS) merged 3 commits intoSep 18, 2026
Merged
Dmitriy Vasyura (dmitrivMS) merged 3 commits into
Dmitriy Vasyura (dmitrivMS) merged 3 commits into
Conversation
Copilot started reviewing on behalf of
Simon Siefke (SimonSiefke)
August 29, 2026 15:17
View session
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes retained notification action view items by assigning disposal ownership to ActionBar.
Changes:
- Stops retaining dropdown action items in the notification template store.
- Adds regression coverage for row reuse.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
notificationsViewer.ts |
Lets ActionBar.clear() dispose replaced action items. |
notificationsList.test.ts |
Tests stable disposable counts after replacement. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 18, 2026
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
September 18, 2026 10:40
Collaborator
|
Simon Siefke (@SimonSiefke) Thank you! |
Nick Trogh (ntrogh)
approved these changes
Sep 18, 2026
Henning Dieterichs (hediet)
approved these changes
Sep 18, 2026
Simon Siefke (SimonSiefke)
deleted the
fix/memory-leak-notification-action-view-item
branch
September 20, 2026 07:39
Abdon Morales (abdonmorales)
pushed a commit
to abdonmorales/vscode-utcs
that referenced
this pull request
Sep 23, 2026
* Fix notification action view item leak * Move notification renderer test to dedicated suite (cherry picked from commit 16c04af)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
When a notification is created, an action view item is added to the notification viewer. But that action item doesn't seem to be removed when the notification is closed or disposed.
Change
The action view item is no longer added to the notification row's lifetime store.
ActionBar.clear()disposes it when the row is reused.Before
When opening and clearing the Notification Center 37 times, 16 notification action, hover, and view callbacks each grow by 37:
After
No more notification action view item leak is detected.
Test Video
test-video.webm