Repository navigation
Reduce floating panel margins for layout consistency - #328963
Merged
Merged
Conversation
…onsistency Co-authored-by: Copilot <copilot@github.com>
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces floating-panel spacing to a consistent 4px inter-card gap.
Changes:
- Removes trailing panel margins.
- Realigns resize sashes with the new gap.
- Adds a spacing regression test.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
floatingPanels.css |
Updates margins and sash geometry. |
layoutService.ts |
Sets the trailing margin to zero. |
layoutService.test.ts |
Verifies the 4px spacing contract. |
…ion consistency Co-authored-by: Copilot <copilot@github.com>
Giuseppe Cianci (Giuspepe)
approved these changes
Aug 4, 2026
Don Jayamanne (DonJayamanne)
added a commit
that referenced
this pull request
Aug 4, 2026
* origin/main: (31 commits) Improve workspace picker preselection (#328995) agentHost: support Codex custom agents and runtime enablement (#328956) Finalizes customEditorPriority proposal. Closes #292379 (#329002) Add Agents window startup A/A experiment trigger (#328454) sessions: show created session pill in response summary (#328984) Fix onboarding microphone picker visibility (#329011) Explains how to develop the markdown editor (#329009) Conditional agent-window auth for signed-out users (#328990) Fix BYOK enterprise policy handling in agent host Agent Host changes for fix/agent-host-byok-enterprise-policy agentHost: drive tool execution from the session input queue (#328989) Make Integrated Browser smoke tests deterministic across build qualities (#328983) Accept box sizing screenshot changes Avoid large Component Fixtures step outputs Remove component fixture box sizing reset fix: guard stale line numbers in test decorations (fixes #328988) sessions: fix maximized side pane toggle (#328974) Add component fixture rendering controls Reduce floating panel margins for layout consistency (#328963) agentHost: support file completions across workspace roots (#328944) ... # Conflicts: # src/vs/sessions/SESSIONS.md # src/vs/sessions/contrib/providers/agentHost/browser/baseAgentHostSessionsProvider.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the floating panel layout to use a 4px inter-card gap by setting the inner (trailing) margin between floating cards to 0px instead of 2px. The changes ensure consistency between the CSS and TypeScript constants, update documentation, and add a test to verify the new spacing.
Floating panel spacing update:
FLOATING_PANEL_INNER_MARGIN) from 2px to 0px inlayoutService.ts, making the inter-card gap 4px instead of 6px. Updated the documentation to reference--vscode-spacing-sizeNone(0px) instead of--vscode-spacing-size20(2px).floatingPanels.cssto usevar(--vscode-spacing-sizeNone)for trailing margins and gaps, replacing previous uses ofvar(--vscode-spacing-size20). This affects margins for panels, sidebars, editors, and sash sizing/positioning. [1] [2] [3] [4] [5] [6] [7]Documentation and comments:
floatingPanels.cssandlayoutService.tsto reflect the new 4px gap and 0px trailing margin, ensuring documentation matches implementation. [1] [2] [3] [4]Testing:
layoutService.test.tsto assert that the leading margin is 4px, trailing margin is 0px, and the total inter-card gap is 4px.These changes keep the floating panel UI consistent and ensure that both code and documentation reflect the intended design.