Repository navigation
fix: memory leak in terminalProcessManager - #326930
Merged
Megan Rogge (meganrogge) merged 2 commits intoJul 22, 2026
Merged
Megan Rogge (meganrogge) merged 2 commits into
Megan Rogge (meganrogge) merged 2 commits into
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Anthony Kim (@anthonykim1)Matched files:
|
Megan Rogge (meganrogge)
approved these changes
Jul 22, 2026
Megan Rogge (meganrogge)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks!
Martin Aeschlimann (aeschli)
approved these changes
Jul 22, 2026
Logan Ramos (lramos15)
approved these changes
Jul 22, 2026
Megan Rogge (meganrogge)
enabled auto-merge (squash)
July 22, 2026 18:02
Simon Siefke (SimonSiefke)
deleted the
fix/terminal-process-manager-memory-leak
branch
July 28, 2026 16:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Uses a
MutableDisposableso resolving a terminal environment replaces the previous listener.Before
When running the same task 37 times, terminal environment listeners grow each time (outlined in red):
After
No more leak is detected for this listener.