Repository navigation
fix: memory leak in abstractRuntimeExtensionsEditor - #326890
Merged
Megan Rogge (meganrogge) merged 1 commit intoJul 22, 2026
Merged
Megan Rogge (meganrogge) merged 1 commit into
Megan Rogge (meganrogge) merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes lifecycle cleanup in the runtime extensions editor to prevent retained list resources and hover disposables.
Changes:
- Registers the runtime extensions list for editor disposal.
- Disposes element-scoped resources when templates are destroyed.
Megan Rogge (meganrogge)
approved these changes
Jul 22, 2026
Megan Rogge (meganrogge)
left a comment
Collaborator
There was a problem hiding this comment.
Thank you!
Martin Aeschlimann (aeschli)
approved these changes
Jul 22, 2026
Logan Ramos (lramos15)
approved these changes
Jul 22, 2026
Simon Siefke (SimonSiefke)
deleted the
fix/memory-leak-abstract-runtime-extensions-editor
branch
July 28, 2026 16:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Registers a disposable in
abstractRuntimeExtensionsEditorso it is properly disposed.Before
When opening two running extensions editors then closing all editors 37 times, the number of various functions seems to grow each time:
After
No more leak is detected.
Test Video
video-edited-3.mp4