Makecode Role UI inconsistencies

[ross-inksmith]

Different parts of the UI will show different subsets of roles, or use different names
(Follow up from Tom Ball (@tballmsft)'s visit 👋)
#1352 overlaps with this.

Fig 1:

Fig 2:

Fig 3:

Fig 4:

Fig 5:

Fig 6:

• Roles defined using the Modules > Configure button display in the dropdown menu (Fig 1), but don't complete with intellisense in javascript. (Actually I'm not sure how to use those in javascript at all)
• Roles defined in extension code will display using the variable name rather than the constructor name. (Fig 3, Code from pxt-jacdac/led/client.ts). Works when annotated
• Roles defined in javascript only show up if an annotated such as //% fixedInstance whenUsed block="LED 4444", don't use either the variable or constructor names (Figs 1, 2, 4). Since this is also a comment, it's stripped if you switch back and forth between blocks and javascript.
• Roles only show up in the simulator dialog once they've been used in a block (Fig 5, 6)

[ross-inksmith]

Discovered an additional inconsistency, the roles available to pxt-jacdac blocks aren't available to the blocks in our wrapper pxt-fwd-edu but the reverse is true

And to expand on the final bullet from the original issue, there's an additional step where the project must be downloaded in order for the roles to then be reassigned. Once this is done, roles can be reassigned wihtout redownloading the project. This might be more of a feature request rather than a bug?

Blank project with pxt-fwd-edu extension on the microbit

Heart buttons added

[ross-inksmith]

Screenshot to make the difference in visible roles in the previous comment clearer