Reject nil module and nil BestIndex result

[mattn]

CreateModule with a nil module silently returned success without registering anything, and a BestIndex implementation returning (nil, nil) crashed with a nil dereference inside the cgo callback. Return proper errors for both.

Summary by CodeRabbit

• Bug Fixes
  • Added validation to prevent errors when virtual table index results are missing.
  • Virtual table modules with invalid definitions now return an error instead of appearing to register successfully.

[coderabbitai]

📝 Walkthrough

Walkthrough

Virtual table handling now reports errors for nil BestIndex results and invalid module values instead of proceeding or silently succeeding.

Changes

Virtual table validation

Layer / File(s)	Summary
BestIndex result validation sqlite3_opt_vtable.go	goVBestIndex checks for a nil IndexResult and returns an error before accessing its fields.
Module registration validation sqlite3_opt_vtable.go	SQLiteConn.CreateModule returns an error when given an invalid or effectively nil module value.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• mattn/go-sqlite3#1419: Adds related nil-result error handling in virtual table cursor opening.
• mattn/go-sqlite3#1430: Also modifies goVBestIndex handling of IndexResult fields.
• mattn/go-sqlite3#1433: Also tightens goVBestIndex handling of IndexResult constraint usage.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: rejecting nil module values and nil BestIndex results.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-vtable-nil-checks

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

sqlite3_opt_vtable.go (1)

696-714: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Reject typed-nil modules before registration.

module == nil does not catch a typed nil such as a nil pointer-to-module assigned to Module, so CreateModule returns success while later goMInit/module callbacks dereference a nil receiver. Add validation that rejects both plain nil and reflection-detected nil module values before the type switch, and cover both cases in tests.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@sqlite3_opt_vtable.go` around lines 696 - 714, Update SQLiteConn.CreateModule
to validate module before the type switch, rejecting both a plain nil interface
and reflection-detected nil values such as nil pointers implementing Module.
Return the existing CreateModule error for either case, and add tests covering
plain nil and typed-nil modules before registration.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@sqlite3_opt_vtable.go`:
- Around line 696-714: Update SQLiteConn.CreateModule to validate module before
the type switch, rejecting both a plain nil interface and reflection-detected
nil values such as nil pointers implementing Module. Return the existing
CreateModule error for either case, and add tests covering plain nil and
typed-nil modules before registration.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8d049dc6-bf5a-4331-b5ae-05092407e2e4

📥 Commits

Reviewing files that changed from the base of the PR and between 2730212 and cad8b71.

📒 Files selected for processing (1)

• sqlite3_opt_vtable.go