Repository navigation
Introduce FacesServletFactory #1861
Description
To facilitate different implementors the FacesServlet should delegate to a Servlet that should be acquired by the FacesServletFactory.
{{ message }}
To facilitate different implementors the FacesServlet should delegate to a Servlet that should be acquired by the FacesServletFactory.
Activity
tandraschko commentedon Nov 18, 2023
whats the usecase for it?
mnriem commentedon Nov 18, 2023
Rought implementation details
Merge pull request #1863 from mnriem/issue-1861-2
tandraschko commentedon Nov 21, 2023
Currently this isnt alligned with other Factories:
class ViewDeclarationLanguageFactory implements FacesWrapper<ViewDeclarationLanguageFactory> {tandraschko commentedon Nov 21, 2023
any reason for this?
BalusC commentedon Nov 21, 2023
Oh this reminds me we still need to add to spec that all factories and factory instances should preferably implement FacesWrapper and that impl should validate that by e.g. emitting warnings. Or perhaps even make it obligatory.
what exactly are you referring to?
tandraschko commentedon Nov 21, 2023
that its implemented without FacesWrapper :)
also we should add faces-config/factory/faces-servlet-factory like other factories before
Merge pull request #1866 from mnriem/issue-1861
tandraschko commentedon Nov 26, 2023
What about the faces-config.xml Changes?
mnriem commentedon Nov 27, 2023
@BalusC @arjantijms Should the latest faces-config XSD be included in the API JAR going forward?
Merge pull request #1869 from mnriem/issue-1861-5_0
tandraschko commentedon Dec 11, 2023
getFacesServlet is still unused in Mojarra? where do you use it?
In MyFaces we do this:
servletContext.addServlet(FACES_SERVLET_NAME, FacesServlet.class);in this case, the FacesServletFactory looks a bit wrong?
public Servlet getFacesServlet(ServletConfig config)should be
public Class<? extends FacesServlet> getFacesServlet()?
mnriem commentedon Dec 11, 2023
@tandraschko The API is correct. The FacesServletFactory is supposed to deliver an instance of the Servlet that the FacesServlet can delegate to.
tandraschko commentedon Dec 12, 2023
Implemented it in MF now: apache/myfaces@3a9e428
please review