Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

refactor: replace deprecated method calls for new client methods - #347

Merged
andrewsg merged 1 commit into
googleapis:masterfrom
MaxxleLLC:storage_issue_346
Jan 5, 2021
Merged

refactor: replace deprecated method calls for new client methods#347
andrewsg merged 1 commit into
googleapis:masterfrom
MaxxleLLC:storage_issue_346

Conversation

@HemangChothani

Copy link
Copy Markdown
Contributor

Fixes #346

@HemangChothani
HemangChothani requested review from a team, andrewsg and tseaver December 17, 2020 13:08
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/python-storage API. label Dec 17, 2020
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 17, 2020
@frankyn frankyn changed the title refactor: remove deprecated method calls refactor: replace deprecated method calls for new client methods Jan 5, 2021

@frankyn frankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me. @andrewsg do you have any concerns?

@andrewsg andrewsg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrewsg
andrewsg merged commit 6d5a667 into googleapis:master Jan 5, 2021
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change deprecated method calls

3 participants