This repository was archived by the owner on Mar 6, 2026. It is now read-only.
feat: wrapped tables - #9
Merged
Merged
Conversation
dizcology
suggested changes
Oct 11, 2022
dizcology
suggested changes
Oct 11, 2022
dizcology
suggested changes
Oct 13, 2022
| _documentai_table: documentai.Document.Page.Table = dataclasses.field( | ||
| init=True, repr=False | ||
| ) | ||
| body_rows: List[List[str]] = dataclasses.field(init=True, repr=False) |
Contributor
There was a problem hiding this comment.
The body rows and header rows perhaps could be cached properties and extracted only when called. Or alternatively, populated in __post_init__ (calling some of the private helper functions extracting rows from documentai.Table).
Contributor
Author
There was a problem hiding this comment.
what would be the benefit of populating it in __post_init__
dizcology
suggested changes
Oct 17, 2022
| paragraphs = [] | ||
| tables = [] | ||
|
|
||
| for line in documentai_page.lines: |
Contributor
There was a problem hiding this comment.
The code for populating lines, paragraphs, and tables could go into post_init, since then the user could also instantiate a wrapped_page by just passing in a documentai_page message (useful when we support in-memory documents).
Contributor
Author
There was a problem hiding this comment.
I don't believe we can support both, since populating the things in post_init would require me to remove them from init. Also there would be no difference between from_documentai_page and using DocumentWrapper()
dizcology
approved these changes
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕
BEGIN_COMMIT_OVERRIDE
chore: wrapped tables
END_COMMIT_OVERRIDE