This repository was archived by the owner on Mar 6, 2026. It is now read-only.
feat: added helper functions to DocumentWrapper - #12
Merged
Conversation
galdawave
commented
Oct 12, 2022
galdawave
commented
Oct 12, 2022
dizcology
suggested changes
Oct 13, 2022
dizcology
suggested changes
Oct 18, 2022
dizcology
reviewed
Oct 19, 2022
| target_string is not None and pattern is not None | ||
| ): | ||
| raise ValueError( | ||
| "Exactly one of target_string and pattern must be specified." |
Contributor
There was a problem hiding this comment.
Maybe "or" instead of "and".
Contributor
Author
There was a problem hiding this comment.
This is checking if both target_string and pattern are populated so it needs an "and" to make sure both are not none.
dizcology
approved these changes
Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕
BEGIN_COMMIT_OVERRIDE
chore: added helper functions to DocumentWrapper
END_COMMIT_OVERRIDE