This repository was archived by the owner on Mar 23, 2026. It is now read-only.
chore: clean up IT - #94
Merged
stephaniewang526 merged 1 commit intoJan 10, 2020
Merged
Conversation
kurtisvg
suggested changes
Jan 9, 2020
Contributor
Author
|
This is only the test not the sample so I thought I should remove it.
…On Thu, Jan 9, 2020, 6:02 PM Kurtis Van Gent ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In samples/src/test/java/com/example/bigquery/RelaxColumnModeIT.java
<#94 (comment)>
:
> @@ -68,10 +68,6 @@ public void testRelaxColumnMode() {
"gcloud_test_table_temp_" + UUID.randomUUID().toString().replace('-', '_');
Schema originalSchema =
Schema.of(
- // The only supported modification you can make to a column's mode is changing it from
- // REQUIRED to NULLABLE
- // Changing a column's mode from REQUIRED to NULLABLE is also called column relaxation
- // INFO: LegacySQLTypeName will be updated to StandardSQLTypeName in release 1.103.0
Do you want to remove this comment? Seems still relevant to the sample.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#94?email_source=notifications&email_token=ABX7TQBSWZD73ZQOICJAN3TQ46UHPA5CNFSM4KE7FWNKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRIUBSY#pullrequestreview-340869323>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABX7TQBLZGQ3RXS7FFV73FLQ46UHPANCNFSM4KE7FWNA>
.
|
Contributor
Oh sorry, that totally make sense. |
kurtisvg
approved these changes
Jan 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=========================================
Coverage 77.32% 77.32%
Complexity 1108 1108
=========================================
Files 73 73
Lines 5915 5915
Branches 645 645
=========================================
Hits 4574 4574
Misses 1014 1014
Partials 327 327Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.