Do not allow warmupPeriod set as zero - #3724
Open
liufuyang wants to merge 1 commit into
Open
Conversation
Author
|
@cpovirk Perhaps you can give a review of this? |
Author
|
@cgdecker Perhaps you can take a look as well? :) |
Author
|
@ronshapiro @kluever Pinging you two here as I saw you changed this ratelimiter recently 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to solve issues like #2730
We encountered this "crazy" issue in production that when setting
warmupPeriod=0, the ratelimiter changed the rate from 1 per second to millions (if not billions) per second.Or simply see this issue by running following code as a test:
When setting

warmupPeriod=0will trigger some downstream slope calculation with some value divide 0: https://github.com/google/guava/blob/master/guava/src/com/google/common/util/concurrent/SmoothRateLimiter.java#L229