Repository navigation
Fix value of the DOWN pass through operation id - #985
Merged
Merged
Conversation
DOWN was defined as 0x01, the same value as UP, which made it an alias of UP. The AV/C Panel Subunit Specification assigns 0x02 to DOWN.
zxzxwu
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PassThroughFrame.OperationId.DOWNwas defined as0x01, the same value asUP, so Python made it an alias ofUPand a received0x02operation id was not recognized as DOWN. The AV/C Panel Subunit Specification (PASS THROUGH operation_id table) assigns0x02to DOWN, and the neighboring values in the enum already follow that table.Added
test_passthrough_operation_id_valuesintests/avrcp_test.py, which checks the UP and DOWN values and that0x02maps to DOWN. It fails before the change and passes after. Ran black, ruff and mypy on the touched files, plus the full test suite (the only failures are the android-netsim transport tests, which need grpcio and fail the same way on main).