Improve robot hear regex of foaas#1654
Conversation
|
👍 This LGTM, but from what I understand this repository has been deprecated. I'm unsure if @technicalpickles will pull it in at this point. This one one of those one off scripts I wrote quickly after someone released FOAAS. Like, I didn't even spell the name right in the filename. lol. Anyway, if you're still using it and want to maintain it, be my guest. 😎 |
|
We're happy to pull it into it's own repo, and would prefer it to be honest. I'll wait for @technicalpickles to comment. |
|
We're in the process of deprecating this repository in favor of separate repositories per script over in #1641 . I can merge this now to get functionality out there, but it'd be better if this was extracted and released as a separate repository. So yeah, go for it @lewisnyman 😁 If you do that, can you let us know on that issue so we can deprecate this script for the package? |
Improve robot hear regex of foaas
|
Released in 2.16.2, thanks! cc #1660 |
|
Woo hoo! Thanks for letting me know. |
I've found that the FOAAS responds when I'm not expecting it to, when Hubot hears any word beginning with 'fu' like fun, future, etc. E.g. hearing
fun time at the bar last night, eh?
… would get a FOAAS response. I think the regex needs improving.
This patch alters it to listen for 'fu' either followed by nothing, or followed by -space- and something (which can now be any number of words, whereas previously it was just a single word).