Skip to content
This repository was archived by the owner on Jun 8, 2023. It is now read-only.

Improve robot hear regex of foaas#1654

Merged
technicalpickles merged 1 commit into
github:masterfrom
joesb:foass-regex
Aug 12, 2015
Merged

Improve robot hear regex of foaas#1654
technicalpickles merged 1 commit into
github:masterfrom
joesb:foass-regex

Conversation

@joesb

@joesb joesb commented Jul 13, 2015

Copy link
Copy Markdown
Contributor

I've found that the FOAAS responds when I'm not expecting it to, when Hubot hears any word beginning with 'fu' like fun, future, etc. E.g. hearing

fun time at the bar last night, eh?

… would get a FOAAS response. I think the regex needs improving.

This patch alters it to listen for 'fu' either followed by nothing, or followed by -space- and something (which can now be any number of words, whereas previously it was just a single word).

@zacechola

Copy link
Copy Markdown
Contributor

👍 This LGTM, but from what I understand this repository has been deprecated. I'm unsure if @technicalpickles will pull it in at this point.

This one one of those one off scripts I wrote quickly after someone released FOAAS. Like, I didn't even spell the name right in the filename. lol.

Anyway, if you're still using it and want to maintain it, be my guest. 😎

@lewisnyman

Copy link
Copy Markdown
Contributor

We're happy to pull it into it's own repo, and would prefer it to be honest. I'll wait for @technicalpickles to comment.

@technicalpickles

Copy link
Copy Markdown
Contributor

We're in the process of deprecating this repository in favor of separate repositories per script over in #1641 . I can merge this now to get functionality out there, but it'd be better if this was extracted and released as a separate repository. So yeah, go for it @lewisnyman 😁

If you do that, can you let us know on that issue so we can deprecate this script for the package?

technicalpickles added a commit that referenced this pull request Aug 12, 2015
Improve robot hear regex of foaas
@technicalpickles technicalpickles merged commit 0b4a58e into github:master Aug 12, 2015
@technicalpickles technicalpickles mentioned this pull request Aug 12, 2015
@technicalpickles

Copy link
Copy Markdown
Contributor

Released in 2.16.2, thanks! cc #1660

@joesb

joesb commented Aug 12, 2015

Copy link
Copy Markdown
Contributor Author

Woo hoo! Thanks for letting me know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants