fix(onboarding): Gate experiment exposure to recently created orgs#117017
Open
jaydgoss wants to merge 1 commit into
Open
fix(onboarding): Gate experiment exposure to recently created orgs#117017jaydgoss wants to merge 1 commit into
jaydgoss wants to merge 1 commit into
Conversation
Existing orgs can land on /onboarding via stale links and login replay, which fired onboarding-scm-experiment exposure on any onboarding mount and contaminated the experiment population. Only report exposure when the org was created within the onboarding window (NEW_ORG_ONBOARDING_WINDOW_MS), since genuine new-org onboarding happens shortly after creation while the contaminating orgs are far older. The returned experiment assignment is unaffected, so onboarding step selection still works for everyone.
afb7130 to
3f5bd7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Existing orgs were firing onboarding experiment exposure after landing on
/onboardingvia stale links. Exposure now only fires for orgs created within the last 7 days, so the experiment population reflects genuine new-org onboarding.onboarding-scm-experimentandonboarding-scm-project-details-experimentreported exposure on every onboarding mount. Existing orgs reach/onboardingvia stale or legacy-format bookmarks (confirmed in api-access and load balancer logs; an auth bug and the onboarding continuation email were ruled out), which contaminated the experiment. Gating onorganization.dateCreatedis fully synchronous and cleanly excludes the contaminating orgs, which are years old.reportExposuredoes not change the returnedinExperimentassignment, so onboarding step selection is unchanged.NEW_ORG_ONBOARDING_WINDOW_MS(7 days) is tunable, and exposure volume is worth confirming after deploy. A project-count alternative was also prototyped.