builder/index.js actually passes UNITY_* env vars now - #18
Closed
Rabadash8820 wants to merge 1 commit into
Closed
Conversation
Member
|
Ah. My mistake! I had made the assumption that everyone changing Javascript files would have node installed. Please use the official workflow. builder/index.js is an automatically generated file. Merging this now would make future PRs unreliable. Just install the latest stable NodeJS and run Please note that this is also why your tests didn't work out. |
frostebite
added a commit
that referenced
this pull request
May 7, 2026
- Add `rm -rf .git` step before fallback checkout to clear corrupted state when branch-matching checkout fails - Fix unit test step: replace jest --testPathPattern with vitest positional filters (same fix as orchestrator PR #18) - Replace all --detectOpenHandles --forceExit --runInBand with vitest --no-file-parallelism Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
frostebite
added a commit
that referenced
this pull request
May 7, 2026
…i→PluginOptions rename (#837) * fix: remove concurrency block from reusable workflow to prevent deadlock When integrity-check.yml calls validate-orchestrator-integration.yml via workflow_call, both workflows resolve github.workflow to the same name ("Integrity"), creating identical concurrency groups. GitHub detects this as a deadlock and cancels the run. Fix: remove concurrency from the reusable workflow entirely — the caller already manages concurrency for the group. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: add linux64RemoveExecutableExtension parameter (default: false) Adds configurable control over the `.x86_64` file extension for StandaloneLinux64 builds. Default is `false` (keep the extension), matching Unity's native behavior. Set `linux64RemoveExecutableExtension: true` to restore the extensionless behavior from v4. Rebased from kitlith's original PR #726. Default flipped for v5. Closes #722 Co-Authored-By: kitlith <kitlith@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: bump production dependencies (minor/patch) - @actions/cache ^4.0.0 → ^4.1.0 - @actions/github ^6.0.0 → ^6.0.1 - commander ^9.0.0 → ^9.5.0 - nanoid ^3.3.1 → ^3.3.12 - reflect-metadata ^0.1.13 → ^0.2.2 - semver ^7.5.2 → ^7.7.4 - yaml ^2.2.2 → ^2.8.4 All minor/patch bumps. Major bumps (@actions/core 3.x, nanoid 5.x ESM) deferred to a separate PR. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: remove legacy CLI bootstrap and unused deps Remove InitCliMode/RunCli, @CliFunction decorator, and CliFunctionsRepository. The only registered CLI mode was `print-input` which is unused — all real CLI functionality lives in the orchestrator repo now. This drops 3 dependencies: - commander-ts (decorator-based CLI, needed reflect-metadata) - reflect-metadata (peer dep of commander-ts) - commander (only used for OptionValues type) Cli.options, Cli.isCliMode, and Cli.query remain — the orchestrator plugin sets these directly without commander. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: rename Cli to PluginOptions, remove cli directory Cli class was a legacy name from when unity-builder had its own CLI. Now it's just an options bridge for plugins — renamed to PluginOptions with a backwards-compatible Cli alias for the orchestrator. Moved from src/model/cli/cli.ts to src/model/plugin-options.ts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(ci): fix orchestrator integration test failures Two issues: 1. jest → vitest: the repo migrated to vitest but the integration workflow still called `npx jest`. Changed to `npx vitest run`. 2. Git checkout corruption: when the orchestrator branch matching the PR doesn't exist, the first checkout fails leaving a corrupted .git directory. The fallback step then hits `fatal: ambiguous argument 'HEAD'`. Fix: add `clean: true` to all fallback checkout steps so they wipe the broken state before re-cloning. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(ci): wipe .git before fallback checkout, fix remaining jest syntax - Add `rm -rf .git` step before fallback checkout to clear corrupted state when branch-matching checkout fails - Fix unit test step: replace jest --testPathPattern with vitest positional filters (same fix as orchestrator PR #18) - Replace all --detectOpenHandles --forceExit --runInBand with vitest --no-file-parallelism Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: simplify plugin mode check --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: kitlith <kitlith@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I modified
src/model/docker.jsin #14, I had not set up your build process locally so I didn't regeneratebuilder/index.js. I still don't really know how to do that, so I just edited this file manually. 😅 The GitHub diff makes it a little hard to see what's going on, since everything is on one line, but if you just Ctrl+F fordocker runin your browser, you should see the string that I changed. When I made this change in my fork, and referenced that commit's SHA in my project repo's workflow, activation finally succeeded. The build still failed, but I think its finally due to bugs in my own project and not in this Action.Per @Jibbajabbafic's and my comments in webbertakken/unity-actions#27, it might be best to merge these changes onto a separate branch locally @webbertakken, then close this PR and open your own, so that the PR checks run with your secrets and hopefully pass (just rerunning the checks on this PR might also work, since they'll be started by you, but idk).
If everything works, this will finally close webbertakken/unity-actions#26.