Use reactphp/async instead of clue/reactphp-block - #163
Conversation
|
Still need to test this, no mysql:5 on arm. |
|
Locally with PHP 8.1 this works fine for me. Can we restart the checks? Some weird failing there with 8.1, 8, 7.3 and HHVM green and only 7.1 failing. |
SimonFrings
left a comment
There was a problem hiding this comment.
@dinooo13 thanks for bringing this up 👍
One little thing below, can you also add some references in your PR description similar to my comment in clue/reactphp-mq#34.
|
Resolved, thanks for the review 👍🏼 |
|
I think something is a bit flaky in the tests on the ci, should we maybe open an issue further investigating this? |
SimonFrings
left a comment
There was a problem hiding this comment.
I think something is a bit flaky in the tests on the ci, should we maybe open an issue further investigating this?
@clue restarted the failed tests, seems like there's been a hickup in one of them. From my end this PR seems fine as it is right now 👍
See https://github.com/reactphp/async
Ref: clue/reactphp-block#67, clue/reactphp-block#68, reactphp/http#464 and clue/reactphp-mq#34