test: fix test failure due to localhost being also ipv6 - #845
Merged
Conversation
Depending on runtime environment, "localhost" might resolve to both IPv4 and IPv6, resulting in an AggregateError in place of an Error.
Contributor
Author
Contributor
Author
|
@titanism could you take a look? |
Collaborator
|
v7.1.0 released to npm – please try it out and let us know if it works for you 🎉 https://github.com/ladjs/supertest/releases/tag/v7.1.0 Thank you for your contributions 🙏 Our efforts to maintain this project are through our work on https://forwardemail.net (@forwardemail) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my MacOS machine:
This caused the "should handle connection error" test to fail, since the error was an AggregateError containing both the 127.0.0.1 and the ::1 failure.
To make this uniform across different test environments, I'm changing the hostname to an IPv4 IP address. (It might be worthwhile to test AggregateError behavior and IPv6 behavior but this is not the goal of this PR.)
Checklist